More options for positioning/anchor, opacity, name max length#266
Conversation
|
@francislavoie is attempting to deploy a commit to the Hacksore's Team Team on Vercel. A member of the Team first needs to authorize it. |
francislavoie
force-pushed
the
options
branch
from
c8e3a08 to
7e8c3f1
Compare
|
Very nice! i think i found some instability where overlayed will just crash but don't yet have a repro. The settings windows minimized is a bit odd for me on macOS, i rarely minimize things. Will look over the code and see if there are any callouts but appreciate the work here. if i ever want to do another release i'll need to kick the dust off of #253 so we can have code signing 😂. |
| }); | ||
| // Start the settings window minimized so it's available but not intrusive | ||
| // The `show` call from the UI will restore/unminimize it. | ||
| settings.minimize().ok(); |
There was a problem hiding this comment.
I think this is the only thing i really don't like. I believe we should just hide it instead of minimize.
Perhaps the best way to solve "how do i unpin" is a FTUE (first time user experience)
There was a problem hiding this comment.
Yeah I thought about that too, but this seemed like the simpler option to me. I also looked at global hotkeys but I have concerns about them conflicting with other apps, so onboarding users to set up a hotkey they like for it would be necessary and that's annoying.
Probably best to go with the FTUE, yeah.
There was a problem hiding this comment.
Okay, reverting the minimize changes, and setting up a FTUE popup on initial launch (with a option in dev mode to reset the FTUE state for testing via the settings panel). Has per-OS-platform wording.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
I added another commit which adds a settings switch (off by default) to hide the taskbar/dock icon while the app is pinned (systray still visible). |
|
Hi @francislavoie Enjoying the improvements and thanks in advance! |
|
Ah okay. I have Linux too (Ubuntu 26.04 on Wayland) so I can give it a shot I guess to see if that works. I only tried it on Windows. |
Ensures the settings window starts minimized and unminimizes when opened. Modifies the pin toggle to target the main overlay window consistently. Broadcasts pin changes to all webviews for consistent state. Persists main window size and position on resize/move events. Adds a pin toggle to the settings page.
|
Rebased and linted. FYI @Hacksore this is ready for another review if you're willing to check it out. I realize it's a big one. |
|
This is really good, it will solve so much confusion 👏 
|
|
So i think the only things i've seen are some crashes/instability, otherwise the new features are great. Let's do this, gonna merge this and let us test canary for a while then we can start new issues with all the bugs we encounter. Good work on this one! |
3 participants
Followup on #240, closes #67 (anchoring)
...if too long. This makes sure the overlay will be limited on width, better to plan consistent layouts if using this with OBS for streaming. I realize resizing the window also does this to a certain extent, but I think having both is good for level of control.In followup commits:
Made the settings window start opened but minimized, made the X button not close but minimize; this gives easier access to toggling unpin (on first-time-use of the app, it's surprising and confusing if you pin and then realize "oh shit how do I unpin aaaaaaaaaa", so I think this is a better default). Users can find the settings pane via their taskbar (on Windows anyway, I don't know if this behaves weird on Mac/Linux)Introduced an FTUE popup on first use which explains how pinning works instead.:(with error message which is kinda scary when opening it up while live on stream.Disclosure: I largely used Github Copilot to write the code changes, but I manually tested and made many minor adjustments by hand afterwards.